Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emulated_hue brightness off by one #34185

Merged
merged 5 commits into from Apr 17, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 14, 2020

Proposed change

Hue uses a max brightness of 254, Home Assistant
uses a max brightness of 255. Values > 127 were
off by one.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Hue uses a max brightness of 254, Home Assistant
uses a max brightness of 255. Values > 127 were
off by one.
@project-bot project-bot bot added this to Needs review in Dev Apr 14, 2020
@bdraco bdraco marked this pull request as draft April 14, 2020 02:38
@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2020

Verified with harmony + emulated_hue I can now get one value higher on brightness

Dev automation moved this from Needs review to Reviewer approved Apr 14, 2020
@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2020

Waiting for user testing in the linked case

This reverts commit 242220a.
@bdraco bdraco marked this pull request as ready for review April 17, 2020 04:48
@bdraco bdraco merged commit 23f278e into home-assistant:dev Apr 17, 2020
Dev automation moved this from Reviewer approved to Done Apr 17, 2020
@lock lock bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Emulated hue - brightness difference in set/get causes device malfunction error
3 participants