Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two more titles from strings.json #34324

Merged
merged 1 commit into from Apr 17, 2020
Merged

Remove two more titles from strings.json #34324

merged 1 commit into from Apr 17, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 17, 2020

Breaking change

Proposed change

Remove titles from Axis as it describes what would be set up, instead of the integration. flow_title is used to describe what is set up (and was already defined).

HomeKit Controller has been updated to reflect the integration name, not what is being set up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with a integration (homekit_controller) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (axis) you are listed as a codeowner for? Thanks!

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Dev automation moved this from Needs review to Reviewer approved Apr 17, 2020
@frenck frenck merged commit 9aee91b into dev Apr 17, 2020
Dev automation moved this from Reviewer approved to Done Apr 17, 2020
@frenck frenck deleted the remove-two-more-titles branch April 17, 2020 07:08
@Jc2k
Copy link
Member

Jc2k commented Apr 17, 2020

Might be missing some wider context here but isn鈥檛 this confusing for people following the step_user flow? When they look at the list of integrations they want to add a homekit accessory (lightbulb) to their system not a HomeKit controller (iOS device).

@balloob
Copy link
Member Author

balloob commented Apr 17, 2020

We moved titles from the config flow out of the config key because it wasn't just used for config flows, but also to just render the name of the integration.

You're right that it is confusing and I'll take a look. Right now we still have the flow_title, but that is sometimes customized hmmm

@balloob balloob mentioned this pull request Apr 17, 2020
44 tasks
@lock lock bot locked and limited conversation to collaborators Apr 18, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants