Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Homekit QR code when pairing #34449

Merged
merged 6 commits into from Apr 21, 2020
Merged

Display Homekit QR code when pairing #34449

merged 6 commits into from Apr 21, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 20, 2020 •
edited

Proposed change

Display Homekit QR code when pairing. No more typing in number or digging though homekit menus to pair.
Screen Shot 2020-04-20 at 10 21 23 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Apr 20, 2020
@bdraco bdraco marked this pull request as draft April 20, 2020 04:08
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 20, 2020
@bdraco bdraco mentioned this pull request Apr 20, 2020
Closed
3 tasks
@bdraco bdraco marked this pull request as ready for review April 20, 2020 15:22
@bdraco bdraco force-pushed the homekit_pairing branch 2 times, most recently from 3cd1c9e to 955d856 Compare April 20, 2020 15:27
@bdraco bdraco mentioned this pull request Apr 20, 2020
Merged
8 tasks
@ctalkington
Copy link
Contributor

ctalkington commented Apr 20, 2020 •
edited

doing some great work for homekit users with your recent contributions!

@bdraco
Display a QR code for homekit pairing
33ccc31 
This will reduce the failure rate with HomeKit
pairing because there is less chance of entry
error.
@bdraco
Add coverage
1e63f70
@bdraco
Test that the qr code is created
792f066
@bdraco
Copy link
Member Author

bdraco commented Apr 21, 2020

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bdraco and others added 3 commits April 21, 2020 21:21
@bdraco
I cannot spell
d9c21f1
@bdraco @balloob
Update homeassistant/components/homekit/__init__.py
c4b3f40 
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco @balloob
Update homeassistant/components/homekit/__init__.py
6005aa7 
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Dev automation moved this from By Code Owner to Reviewer approved Apr 21, 2020
@bdraco
Copy link
Member Author

bdraco commented Apr 21, 2020

retested, still works

@bdraco bdraco merged commit d06fce6 into home-assistant:dev Apr 21, 2020
Dev automation moved this from Reviewer approved to Done Apr 21, 2020
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: homekit small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdraco @ctalkington @balloob @homeassistant