New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Islamic prayer times naming #34784
Merged
frenck
merged 25 commits into
home-assistant:dev
from
engrbm87:islamic-prayer-config-flow
Apr 29, 2020
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b41c566
Add Islamic Prayer Times config_flow
engrbm87 211b60a
Add Islamic Prayer Times config_flow
engrbm87 a98ee58
Merge branch 'islamic-prayer-config-flow' of https://github.com/engrb…
engrbm87 4fd2cea
handle options update and fix tests
engrbm87 87460d0
fix sensor update handling
engrbm87 8336df4
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 0e544e5
fix pylint
engrbm87 d412176
fix scheduled update and add test
engrbm87 8f9d01b
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 2a61a7d
update test_init
engrbm87 d5e6dfb
update flow options to show drop list
engrbm87 da7f34c
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 33e757e
Merge branch 'dev' into islamic-prayer-config-flow
engrbm87 25547a3
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 ee453f6
clean up code
engrbm87 3c75168
Merge branch 'islamic-prayer-config-flow' of https://github.com/engrb…
engrbm87 92ca24c
async scheduling and revert state to timestamp
engrbm87 d2b9782
fix update retry method
engrbm87 a1c57a9
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 d8d3df0
update strings
engrbm87 f3dc053
keep title as root key
engrbm87 60e56ca
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 300220d
fix sensor naming and calculation_method key
engrbm87 41dc6f0
fix strings
engrbm87 3e2bfbb
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
engrbm87 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 20 additions & 20 deletions
40
homeassistant/components/islamic_prayer_times/translations/en.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
{ | ||
"config": { | ||
"abort": { | ||
"one_instance_allowed": "Only a single instance is necessary." | ||
}, | ||
"step": { | ||
"user": { | ||
"description": "Do you want to set up Islamic Prayer Times?", | ||
"title": "Set up Islamic Prayer Times" | ||
} | ||
} | ||
"config": { | ||
"abort": { | ||
"one_instance_allowed": "Only a single instance is necessary." | ||
}, | ||
"options": { | ||
"step": { | ||
"init": { | ||
"data": { | ||
"calc_method": "Prayer calculation method" | ||
} | ||
} | ||
"step": { | ||
"user": { | ||
"description": "Do you want to set up Islamic Prayer Times?", | ||
"title": "Set up Islamic Prayer Times" | ||
} | ||
} | ||
}, | ||
"options": { | ||
"step": { | ||
"init": { | ||
"data": { | ||
"calculation_method": "Prayer calculation method" | ||
} | ||
}, | ||
"title": "Islamic Prayer Times" | ||
} | ||
} | ||
} | ||
}, | ||
"title": "Islamic Prayer Times" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging this we should update the translation key in lokalise or else all existing translations will be lost .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that done via the key editor?
https://docs.lokalise.com/en/articles/2059009-key-editor