Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowner to Monoprice integration #35111

Merged
merged 1 commit into from May 3, 2020

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented May 3, 2020

Proposed change

In the past few weeks I practically rewritten this integration, so adding myself as a codeowner.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev May 3, 2020
@probot-home-assistant probot-home-assistant bot added integration: monoprice small-pr PRs with less than 30 lines. labels May 3, 2020
@probot-home-assistant
Copy link

Hey there @etsinko, mind taking a look at this pull request as its been labeled with a integration (monoprice) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@OnFreund OnFreund mentioned this pull request May 3, 2020
20 tasks
@MartinHjelmare MartinHjelmare changed the title Adding myself as codeowner to the Monoprice integration Add codeowner to Monoprice integration May 3, 2020
Dev automation moved this from Needs review to Reviewer approved May 3, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit a44724f into home-assistant:dev May 3, 2020
Dev automation moved this from Reviewer approved to Done May 3, 2020
@OnFreund OnFreund deleted the monoprice_codeowner branch May 3, 2020 11:55
@lock lock bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants