Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SCAN_INTERVAL instead of Throttle to allow manual todoist updates #35297

Merged
merged 2 commits into from Jun 2, 2020

Conversation

boralyl
Copy link
Contributor

@boralyl boralyl commented May 6, 2020

Proposed change

This fixes #35105 . It does so by removing the Throttle decorator from the update method and replaces it with a SCAN_INTERVAL of the same duration. This alllows a user to manually update the integration by using the homeassistant.update_entity service.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
calendar:
  - platform: todoist
    token: !secret todoist_token

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@MartinHjelmare MartinHjelmare changed the title Use SCAN_INTERVAL instead of Throttle to allow manual updates. Use SCAN_INTERVAL instead of Throttle to allow manual todoist updates May 7, 2020
@MartinHjelmare MartinHjelmare added this to By Code Owner in Dev May 9, 2020
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okey once tests pass

Dev automation moved this from By Code Owner to Reviewer approved May 29, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @boralyl 馃憤

@frenck frenck merged commit e347f37 into home-assistant:dev Jun 2, 2020
Dev automation moved this from Reviewer approved to Done Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Todoist integration does not react to homeassistant.update_entity service
4 participants