Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in services.yaml for squeezebox component #35548

Merged
merged 1 commit into from May 12, 2020

Conversation

rajlaud
Copy link
Contributor

@rajlaud rajlaud commented May 12, 2020

Proposed change

Fix examples in services.yaml for squeezebox.call_query and squeezebox.call_method. The query parameters should be a list.

Type of change

  • Dependency upgrade
  • [X ] Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Dev automation moved this from Needs review to Reviewer approved May 12, 2020
@frenck
Copy link
Member

frenck commented May 12, 2020

Thanks, @rajlaud 馃憤

@frenck frenck merged commit 79a313d into home-assistant:dev May 12, 2020
Dev automation moved this from Reviewer approved to Done May 12, 2020
@rajlaud rajlaud deleted the squeezebox-fix-example branch May 12, 2020 19:48
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants