Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to discovery API #35624

Merged
merged 1 commit into from May 15, 2020
Merged

Add more information to discovery API #35624

merged 1 commit into from May 15, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented May 14, 2020

Proposed change

Add more information to the /api/discovery_info endpoint.
Mainly, external_url, internal_url and the instance UUID.

Response:

{"base_url": "http://test.local", "external_url": null, "internal_url": "http://test.local", "location_name": "Test", "requires_api_password": true, "uuid": "3ae7b1eaa31340fb8fa403de8507908f", "version": "0.111.0.dev0"}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (api) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{"base_url": "https://snip:8123", "external_url": "https://snip:8123", "internal_url": null, "location_name": "snip", "requires_api_password": true, "uuid": "snip", "version": "0.110.0.dev0"}

Tested and working as expected

Dev automation moved this from Needs review to Reviewer approved May 14, 2020
@frenck frenck merged commit ddb5ed9 into dev May 15, 2020
Dev automation moved this from Reviewer approved to Done May 15, 2020
@frenck frenck deleted the frenck-2020-0532 branch May 15, 2020 11:29
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants