New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add huawei_lte sensor for number of unread sms #35665
Add huawei_lte sensor for number of unread sms #35665
Conversation
Hi @fphammerle, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
7eaed2e
to
643bfed
Compare
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
4cb71b8
to
1a76907
Compare
Added myself to list of codeowners I am not sure how to add appropriate docs The relevant docs page does not yet mention any other sensors: Could you maybe give me a hint how to proceed? |
That is the correct location @fphammerle. The fact that it is missing any information about other sensors is an error I would say. |
Thanks a lot for your immediate answers I created a small docs PR here: https://github.com/home-assistant/home-assistant.io/pull/13454/files |
1a76907
to
1b49f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fphammerle 👍
LGTM ✅
Proposed change
Added a sensor counting number of unread SMS via
huawei_lte
integration.I'd like to trigger an automation when text messages arrive.
API: https://github.com/Salamek/huawei-lte-api/blob/1.4.12/huawei_lte_api/api/Sms.py#L13
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: