Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add huawei_lte sensor for number of unread sms #35665

Merged
merged 2 commits into from Jun 3, 2020

Conversation

fphammerle
Copy link
Contributor

@fphammerle fphammerle commented May 15, 2020

Proposed change

Added a sensor counting number of unread SMS via huawei_lte integration.

I'd like to trigger an automation when text messages arrive.

API: https://github.com/Salamek/huawei-lte-api/blob/1.4.12/huawei_lte_api/api/Sms.py#L13

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Contributor

Hi @fphammerle,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@frenck
Copy link
Member

frenck commented May 15, 2020

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

@fphammerle fphammerle force-pushed the huawei-lte-sensor-sms-unread branch from 4cb71b8 to 1a76907 Compare May 15, 2020 17:44
@fphammerle
Copy link
Contributor Author

Added myself to list of codeowners

I am not sure how to add appropriate docs

The relevant docs page does not yet mention any other sensors:
https://github.com/home-assistant/home-assistant.io/blob/bdb8e5becda29c103302106bdfdbed3f6229efed/source/_integrations/huawei_lte.markdown

Could you maybe give me a hint how to proceed?

@frenck
Copy link
Member

frenck commented May 15, 2020

That is the correct location @fphammerle.

The fact that it is missing any information about other sensors is an error I would say.

@fphammerle
Copy link
Contributor Author

Thanks a lot for your immediate answers

I created a small docs PR here: https://github.com/home-assistant/home-assistant.io/pull/13454/files

@MartinHjelmare MartinHjelmare changed the title huawei_lte: added sensor for number of unread sms Add huawei_lte sensor for number of unread sms May 16, 2020
@fphammerle fphammerle force-pushed the huawei-lte-sensor-sms-unread branch from 1a76907 to 1b49f49 Compare May 30, 2020 08:43
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fphammerle 👍

LGTM ✅

Dev automation moved this from Needs review to Reviewer approved Jun 3, 2020
@frenck frenck merged commit 8ccdaf2 into home-assistant:dev Jun 3, 2020
Dev automation moved this from Reviewer approved to Done Jun 3, 2020
frenck pushed a commit to home-assistant/home-assistant.io that referenced this pull request Jun 3, 2020
@fphammerle fphammerle deleted the huawei-lte-sensor-sms-unread branch June 3, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants