New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service registration supported features check #35718
Fix service registration supported features check #35718
Conversation
Looks good. Will review once tests pass. |
Hi @ctalkington, can you look at my changes in roku integration? Seems codeowners bot doesn't work for updated PRs |
@chmielowiec roku doesnt support pause command though its possible to call play, to pause, just no discrete option |
working on roku pause updates which had been on my mind anyways due to voice control. should make PR this simplier |
@ctalkington Should I rebase onto your branch? |
I dont think itll merge conflict so no need to do anything atm until one or other is merged |
62e54d7
to
4662311
Compare
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
73c4c40
to
43ac02a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@MartinHjelmare Could you review the source PR #35679 of this bug? It's waiting for more core reviews. |
Breaking change
Proposed change
Fixes bug found by @elupus in #35679 (comment)
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: