Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service registration supported features check #35718

Merged

Conversation

chmielowiec
Copy link
Contributor

@chmielowiec chmielowiec commented May 16, 2020

Breaking change

Proposed change

Fixes bug found by @elupus in #35679 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels May 16, 2020
@project-bot project-bot bot added this to Needs review in Dev May 16, 2020
@chmielowiec chmielowiec mentioned this pull request May 16, 2020
20 tasks
@chmielowiec chmielowiec marked this pull request as ready for review May 16, 2020 21:41
@elupus
Copy link
Contributor

elupus commented May 17, 2020

Looks good. Will review once tests pass.

@chmielowiec
Copy link
Contributor Author

Hi @ctalkington, can you look at my changes in roku integration? Seems codeowners bot doesn't work for updated PRs

@ctalkington
Copy link
Contributor

@chmielowiec roku doesnt support pause command though its possible to call play, to pause, just no discrete option

@ctalkington
Copy link
Contributor

working on roku pause updates which had been on my mind anyways due to voice control.

#35991

should make PR this simplier

@chmielowiec
Copy link
Contributor Author

working on roku pause updates which had been on my mind anyways due to voice control.

#35991

should make PR this simplier

@ctalkington Should I rebase onto your branch?

@ctalkington
Copy link
Contributor

I dont think itll merge conflict so no need to do anything atm until one or other is merged

tests/helpers/test_service.py Outdated Show resolved Hide resolved
tests/helpers/test_service.py Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress May 22, 2020
Dev automation moved this from Review in progress to Reviewer approved May 23, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare added this to the 0.110.2 milestone May 23, 2020
@MartinHjelmare MartinHjelmare merged commit d21cfd8 into home-assistant:dev May 23, 2020
Dev automation moved this from Reviewer approved to Done May 23, 2020
@frenck frenck mentioned this pull request May 24, 2020
@chmielowiec
Copy link
Contributor Author

@MartinHjelmare Could you review the source PR #35679 of this bug? It's waiting for more core reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants