Fallback lg_soundbar sound mode on unknown value

[teldri]

Proposed change

Make the "lg_soundbar" component crash free in case of equaliser settings that the temescal library does not know.

A issue has been created in the temescal repro to fix the unknown equaliser.
google/python-temescal#2

It´s most likley that LG will extend the equalisers in their soundbar(s) in future again. This fix or something similar should be applied in order to prevent bad user experience in that case.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
discovery:

Additional information

• This PR fixes or closes issue:
  Python Issue for Media_Player #35825
  Error in homeassistant/components/lg_soundbar/media_player.py #32832
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[homeassistant]

Hi @teldri,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[teldri]

Hi @homeassistant,

I fixed the cla-error. Do I nned to do something to get this label removed?

[MartinHjelmare]

This looks like it should be fixed in the library instead.

[MartinHjelmare]

Entity state properties should not have side effects. Please move this to eg update method.

[teldri]

This looks like it should be fixed in the library instead.

I agree that it would be the optimum that it´s handeled by the library.
But it´s not the case and changing that would require changes in the lib as well as in this component.

This hacky approch is for sure not the optimum, but I´m as a user prefer to have a equaliser setting named e.g.: "unknown 18" instead of not beeing able to select the setting at all.
Because the side effect is also that if I select the unknown setting using the lg app or the soundbars remote, in the lovelace dashboard I don´t see any selected sound mode.

I made a PR in the librarys repro to fix the missing sound mode. If that get´s accepted I would do another PR to there to handle that problem in the lib it´s self. It just seems kind if inactive to me and I´m not expecting too much.
Sorry writing half a book in this comment.

[MartinHjelmare]

I think it's ok for now if we add a comment.