Auth and headers support for REST sensor #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we should supersede this PR with an |
|
Let's leave the |
balloob
requested changes
Oct 2, 2016
| def setup_platform(hass, config, add_devices, discovery_info=None): | ||
| """Setup the REST binary sensor.""" | ||
| name = config.get(CONF_NAME) | ||
| resource = config.get(CONF_RESOURCE) | ||
| method = config.get(CONF_METHOD) | ||
| payload = config.get(CONF_PAYLOAD) | ||
| verify_ssl = config.get(CONF_VERIFY_SSL) | ||
| username = config.get(CONF_USERNAME) | ||
| password = config.get(CONF_PASSWORD) | ||
| headers = json.loads(config.get(CONF_HEADERS, '{}')) |
There was a problem hiding this comment.
Specify default in PLATFORM_SCHEMA. Also, YAML parses JSON so I doubt the string is really valid JSON here.
There was a problem hiding this comment.
We should also never expect JSON in YAML. Just make it a dict:
binary_sensor:
platform: rest
headers:
hello: worldThus validation it as {cv.string: cv.string} will do.
balloob
approved these changes
Oct 4, 2016
|
🐬 |
hartmms
pushed a commit
to hartmms/home-assistant
that referenced
this pull request
Oct 5, 2016
* Add auth and header support * Update header part
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Support for HTTP authentication and headers for the REST sensor.
This will require an update of the REST Binary sensor and the PI Hole sensor.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#1050
Example entry for
configuration.yaml(if applicable):With the configuration sample from above the header will look like this:
Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices, web services, or a:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.