Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONVIF preset warning #36110

Merged
merged 1 commit into from May 25, 2020
Merged

Conversation

hunterjm
Copy link
Member

Proposed change

The warning produced when an invalid preset was selected used the wrong join.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@hunterjm hunterjm added this to the 0.110.3 milestone May 25, 2020
@project-bot project-bot bot added this to Needs review in Dev May 25, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 25, 2020
Dev automation moved this from By Code Owner to Reviewer approved May 25, 2020
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgtobi cgtobi merged commit 5dfae0e into home-assistant:dev May 25, 2020
Dev automation moved this from Reviewer approved to Done May 25, 2020
frenck pushed a commit that referenced this pull request May 26, 2020
@frenck frenck mentioned this pull request May 26, 2020
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Onvif integration AttributeError: 'list' object has no attribute 'join'
4 participants