Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugwise to async and config_flow switch part #36383

Merged

Conversation

CoMPaTech
Copy link
Contributor

Proposed change

See #33691 as 'parent'-PR. This PR is the last of three 'child'-PRs for the parent. It adds the switch platform providing for Plugwise 'Plugs' in climate setups.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This PR accompanies #33691 (and #36219) but provides additional binary_sensors for climate setups with heater elements. This concludes the changes started in #33691 (async, config-flow and multiple platforms) - leaving code improvement by adding tests which is currently in draft state (as binary_sensor and switch still needed to be added)

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @bouwew, mind taking a look at this pull request as its been labeled with a integration (plugwise) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Jun 2, 2020
@bouwew
Copy link
Contributor

bouwew commented Jun 2, 2020

The final Plugwise-PR :)

Looking good, approved.

@CoMPaTech
Copy link
Contributor Author

Much cleaner, we really need to improve our if-statements. Tnx for the valuable reviews and lessons learned!

Tom Scholten and others added 4 commits June 2, 2020 19:42
@CoMPaTech CoMPaTech force-pushed the plugwise-async-platform-33691-add-switch branch from 55d0d80 to 4a5b30a Compare June 2, 2020 17:42
Dev automation moved this from Needs review to Reviewer approved Jun 2, 2020
@bdraco bdraco merged commit 61c08e7 into home-assistant:dev Jun 2, 2020
Dev automation moved this from Reviewer approved to Done Jun 2, 2020
@CoMPaTech
Copy link
Contributor Author

Tnx for all your reviews @bdraco - highly appreciated!

@CoMPaTech CoMPaTech deleted the plugwise-async-platform-33691-add-switch branch July 4, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants