-
-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugwise to async and config_flow switch part #36383
Merged
bdraco
merged 4 commits into
home-assistant:dev
from
plugwise:plugwise-async-platform-33691-add-switch
Jun 2, 2020
Merged
Update plugwise to async and config_flow switch part #36383
bdraco
merged 4 commits into
home-assistant:dev
from
plugwise:plugwise-async-platform-33691-add-switch
Jun 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final Plugwise-PR :) Looking good, approved. |
bdraco
reviewed
Jun 2, 2020
bdraco
reviewed
Jun 2, 2020
bdraco
reviewed
Jun 2, 2020
Much cleaner, we really need to improve our if-statements. Tnx for the valuable reviews and lessons learned! |
bdraco
reviewed
Jun 2, 2020
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
CoMPaTech
force-pushed
the
plugwise-async-platform-33691-add-switch
branch
from
June 2, 2020 17:42
55d0d80
to
4a5b30a
Compare
bdraco
approved these changes
Jun 2, 2020
8 tasks
Tnx for all your reviews @bdraco - highly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
See #33691 as 'parent'-PR. This PR is the last of three 'child'-PRs for the parent. It adds the
switch
platform providing for Plugwise 'Plugs' in climate setups.Type of change
Additional information
This PR accompanies #33691 (and #36219) but provides additional binary_sensors for climate setups with heater elements. This concludes the changes started in #33691 (async, config-flow and multiple platforms) - leaving code improvement by adding tests which is currently in draft state (as binary_sensor and switch still needed to be added)
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following [Integration Quality Scale][quality-scale]: