Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynalite to explicitly check valid device class #36418

Merged
merged 3 commits into from Jun 4, 2020

Conversation

ziv1234
Copy link
Contributor

@ziv1234 ziv1234 commented Jun 3, 2020

Breaking change

No

Proposed change

Per ask from Martin on PR #34663, reverted one of the previous changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: dynalite small-pr PRs with less than 30 lines. labels Jun 3, 2020
@project-bot project-bot bot added this to Needs review in Dev Jun 3, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 3, 2020
…e commit

and the cv rules prevent an input that would get to that flow
@MartinHjelmare MartinHjelmare changed the title Dynalite - fix to explicitly check for legality of device class Fix Dynalite to explicitly check valid device class Jun 4, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Jun 4, 2020
@ziv1234
Copy link
Contributor Author

ziv1234 commented Jun 4, 2020

Thank you. Sorry it took me so long to get to these 2 lines of code...

@MartinHjelmare MartinHjelmare merged commit 1edbdcb into home-assistant:dev Jun 4, 2020
Dev automation moved this from Reviewer approved to Done Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants