Fix for returning zero erroneously #36460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for returning zero erroneously: error on a value of exactly 0.0000W. This happens sometimes and in all normal use cases does not represent accurate data, usually the homeassistant server is powered from the utility power and draws something. This allows scripts to use "if total power less than X" without them triggering periodically by mistake.
probot-home-assistant
bot
added
integration: dte_energy_bridge
small-pr
MartinHjelmare
requested changes
Jun 5, 2020
| @@ -104,6 +104,18 @@ def update(self): | |||
| return | |||
|
|
|||
| val = float(response_split[0]) | |||
|
|
|||
| # A workaround for a bug in the DTE energy bridge. | |||
There was a problem hiding this comment.
These quirks should be handled by a 3rd party library. We won't accept more changes to this integration until the device specific interface code and data parsing has been moved to a standalone library published on PyPI.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for returning zero erroneously: error on a value of exactly 0.0000W. This happens sometimes and in all normal use cases does not represent accurate data, usually the homeassistant server is powered from the utility power and draws something. This allows scripts to use "if total power less than X" without them triggering periodically by mistake.
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: