Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nx584 SCAN_INTERVAL to 10 seconds #36581

Merged
merged 1 commit into from Jun 9, 2020
Merged

Change nx584 SCAN_INTERVAL to 10 seconds #36581

merged 1 commit into from Jun 9, 2020

Conversation

mreiling
Copy link
Contributor

@mreiling mreiling commented Jun 8, 2020

Breaking change

Proposed change

Increased the scan interval from 30 seconds to 10 seconds. Ideally this integration would be updated to no longer poll and be event driven, like the binary_sensory for this component. Until then, updating the SCAN_INTERVAL to a more useful 10 seconds makes this slightly more responsive. Reacting to things like the ALARM_TRIGGERED with a 30 second delay is not ideal.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [X ] The code change is tested and works locally.
  • [X ] Local tests pass. Your PR cannot be merged unless tests pass
  • [X ] There is no commented out code in this PR.
  • [X ] I have followed the development checklist
  • [X ] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jun 8, 2020
@MartinHjelmare MartinHjelmare changed the title Changed SCAN_INTERVAL to 10 seconds Change nx584 SCAN_INTERVAL to 10 seconds Jun 9, 2020
@MartinHjelmare
Copy link
Member

Please explain the reason for the change in the PR description.

@mreiling
Copy link
Contributor Author

mreiling commented Jun 9, 2020

Okay, updated the proposed change. Thanks

@MartinHjelmare
Copy link
Member

Where did you explain the reason for the change?

@mreiling
Copy link
Contributor Author

mreiling commented Jun 9, 2020

Proposed Change

Increased the scan interval from 30 seconds to 10 seconds. Ideally this integration would be updated to no longer poll and be event driven, like the binary_sensory for this component. Until then, updating the SCAN_INTERVAL to a more useful 10 seconds makes this slightly more responsive. Reacting to things like the ALARM_TRIGGERED with a 30 second delay is not ideal.

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Jun 9, 2020

Side note: The text won't show in the rendered markdown if you put text within this block in the PR description:

<!-- 
-->

Dev automation moved this from Needs review to Reviewer approved Jun 9, 2020
@MartinHjelmare MartinHjelmare merged commit 1169ac5 into home-assistant:dev Jun 9, 2020
Dev automation moved this from Reviewer approved to Done Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants