Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish state changes to Zabbix #36659

Merged
merged 48 commits into from Oct 9, 2020
Merged

Conversation

rusitschka
Copy link
Contributor

@rusitschka rusitschka commented Jun 11, 2020

Proposed change

The Zabbix component is currently used to retrieve alert data from Zabbix into Home Assistant. This PR adds the possibility to submit state changes from Home Assistant into Zabbix - similar to, e.g. Recorder (to DB), or Influx components.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
zabbix:
  host: zabbix.example.com
  path: ""
  ssl: true
  username: !secret zabbix_username
  password: !secret zabbix_password
  publish_states_host: homeassistant
  exclude:
    domains:
      - device_tracker
    entities:
      - sun.sun
      - sensor.fritz_netmonitor
      - sensor.time

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@rusitschka
Copy link
Contributor Author

@MartinHjelmare thanks for your feedback. I implemented your suggested changes.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three comments left to resolve.

homeassistant/components/zabbix/__init__.py Outdated Show resolved Hide resolved
@rusitschka
Copy link
Contributor Author

rusitschka commented Oct 6, 2020

I just changed two things - what's the third one? Found it :-)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare
Copy link
Member

Please add a link to a docs PR in the PR description. Then we can merge.

@rusitschka
Copy link
Contributor Author

Please add a link to a docs PR in the PR description. Then we can merge.

Done

@MartinHjelmare
Copy link
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit a9adc2a into home-assistant:dev Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

5 participants