Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history api without constraints #36979

Merged
merged 1 commit into from Jun 22, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 21, 2020

Work was done on top of all the other history changes #36963

This should cherry-pick cleanly back to 0.111 if we want to tag it, but it didn't seem urgent to fix. I can also rebase if needed.

Proposed change

If the history api was called without a constraint it is expected to return the entire history. This regressed in 0.111 but we didn't notice since there is no UI that calls it without a constraint and docs don't mention this is a valid way to call the history api (but it did work before) see https://developers.home-assistant.io/docs/api/rest/#get-apihistoryperiodtimestamp

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @ChristianKuehnel, mind taking a look at this pull request as its been labeled with a integration (plant) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (statistics) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (history) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Jun 22, 2020
@balloob
Copy link
Member

balloob commented Jun 22, 2020

Very nice improvements ! 馃帀

@bdraco bdraco force-pushed the history_without_params_fix branch from b939dea to a937342 Compare June 22, 2020 14:25
@bdraco bdraco merged commit e19c97a into home-assistant:dev Jun 22, 2020
Dev automation moved this from Reviewer approved to Done Jun 22, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

REST API for historical state changes broken
4 participants