Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Axis library to support fence guard events #37007

Merged
merged 1 commit into from Jun 22, 2020

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 22, 2020

Proposed change

Add support for fence guard events to Axis integration.

Release: https://github.com/Kane610/axis/releases/tag/v33
Compare view: Kane610/axis@v32...v33

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jun 22, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 22, 2020
@Kane610 Kane610 self-assigned this Jun 22, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 馃憤

I've updated the PR description to include links to the package, which makes it easy to see what changed during review. This saves the need for the reviewer to look it up. Could you please include those next time? 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Jun 22, 2020
@Kane610
Copy link
Member Author

Kane610 commented Jun 22, 2020

@frenck sure, I first thought it got added automatically. Could this be automated?

@frenck frenck merged commit 02d94f2 into home-assistant:dev Jun 22, 2020
Dev automation moved this from Reviewer approved to Done Jun 22, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
@Kane610 Kane610 deleted the axis-fence_guard_event branch July 6, 2020 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants