Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Centralite Pearl thermostat modes #37065

Merged
merged 1 commit into from Jun 24, 2020

Conversation

Adminiuga
Copy link
Contributor

Breaking change

No

Proposed change

Change the way Centralite Pearl Thermostat handles current HVAC actions based on running_state attribute

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @dmulcahey, mind taking a look at this pull request as its been labeled with an integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 24, 2020
@Adminiuga Adminiuga added this to the 0.112.0 milestone Jun 24, 2020
@Adminiuga Adminiuga requested a review from dmulcahey June 24, 2020 19:59
Dev automation moved this from By Code Owner to Reviewer approved Jun 24, 2020
@dmulcahey dmulcahey merged commit 47220ae into home-assistant:dev Jun 24, 2020
Dev automation moved this from Reviewer approved to Done Jun 24, 2020
@Adminiuga Adminiuga deleted the ac/zha-centralite-climate branch September 5, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

ZHA Climate reporting climate state incorrectly
4 participants