New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for glob matching in InfluxDB filters #37069
Conversation
Since I realize changes to existing tests is something which raises flags in a review wanted to pre-emptively explain my reasoning above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the refactor that is not related to the filtering from this PR. We should keep the PR scope minimal.
@MartinHjelmare I'm not gonna lie, that was painful. I really liked my refactor, I cleaned up a lot of stuff. But I get it, keep it small. I put all of the excluded work into a new branch so I can come back to it later. PR is much much smaller now. |
I appreciate the work and I think refactoring the integration is a good plan. We should just take it in smaller steps. That will allow us to move faster in total with less risk. |
@MartinHjelmare it still says "Changes requested" but that change was to remove the unreleated refactoring changes which is done now right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@MartinHjelmare Can it be merged or is there additional review required? Or is this more that its too late for 0.112 and has to wait for 0.113 to open up? |
We can merge. It'll go out in 0.113. 馃憤 |
Breaking change
InfluxDB was not using the common filtering logic shared by
recorder
,logbook
,homekit
, etc. and as a result had filtering logic that is inconsistent with the filtering logic of every other recorder-like component. This has been corrected causing the following changes in filtering logic:Proposed change
This is a follow-up to my recent PR: #36913. I want to bring glob filtering capability to InfluxDB as well since it is also a recorder-like component with an identical filtering config. Users would have a reasonable expectation that the Influx component has identical behavior to
recorder,
logbook` and the others when it comes to entity filtering capability. Unfortunately that is not currently the case since Influx does not currently share the common filtering logic and instead has created its own.This PR therefore makes the following changes:
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: