Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Homekit remote support for devices without play/pause #37180

Conversation

nickw444
Copy link
Contributor

@nickw444 nickw444 commented Jun 27, 2020

Breaking change

Proposed change

Fixes #36679: Ensures the homekit_tv_remote_key_pressed event is fired for all keys, even when the underlying media player does not support play/pause.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

# Configure a default setup of Home Assistant (frontend, api, etc)
default_config:

# Text to speech
tts:
  - platform: google_translate

group: !include groups.yaml
automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml

homekit:
  name: "Hass Test"

homeassistant:
  customize:
    media_player.media_room_tv:
      device_class: tv

input_boolean:
  tv_state:
    name: TV Power

input_select:
  tv_source:
    name: TV Source
    options:
      - Watch Apple TV
      - Watch Blu-ray
      - Play PS3
      - Play Xbox


media_player:
  - platform: universal
    name: Media Room TV
    commands:
      turn_on:
        service: input_boolean.turn_on
        data:
          entity_id: input_boolean.tv_state
      turn_off:
        service: input_boolean.turn_off
        data:
          entity_id: input_boolean.tv_state
      volume_down:
        service: logbook.log
        data:
          name: "Demo TV"
          message: "volume_down"
      volume_up:
        service: logbook.log
        data:
          name: "Demo TV"
          message: "volume_up"
      select_source:
        service: input_select.select_option
        data_template:
          entity_id: input_select.tv_source
          option: "{{ source }}"
    attributes:
      state: input_boolean.tv_state
      source: input_select.tv_source
      source_list: input_select.tv_source|options

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@nickw444 nickw444 marked this pull request as ready for review June 27, 2020 23:54
Dev automation moved this from Needs review to Reviewer approved Jul 25, 2020
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is unrelated. I re-ran the CI

@bdraco bdraco merged commit 7599997 into home-assistant:dev Jul 25, 2020
Dev automation moved this from Reviewer approved to Done Jul 25, 2020
@nickw444 nickw444 deleted the nwhyte/enable-remote-for-non-play-pause-media branch July 26, 2020 00:59
@nickw444
Copy link
Contributor Author

Thanks for your help on this one @bdraco (and also for all your recent amazing contributions across core 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Fire events on homekit TV remote key press
3 participants