New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Guardian services to entity platform services #37189
Conversation
platform = entity_platform.current_platform.get() | ||
|
||
for service_name, schema, method in [ | ||
(SERVICE_DISABLE_AP, None, "async_disable_ap"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we target the entities without entity_id or area_id in the service call data (service schema)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you're right. Entity Platform doesn't handle this case. I guess it's broken now 馃し
Proposed change
Per #37188 (comment), this PR moves all of Guardian's services to entity platform services (so that more than one Guardian device can be accommodated).
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: