Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Guardian services to entity platform services #37189

Merged
merged 4 commits into from Jun 30, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jun 28, 2020

Proposed change

Per #37188 (comment), this PR moves all of Guardian's services to entity platform services (so that more than one Guardian device can be accommodated).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@bachya bachya self-assigned this Jun 28, 2020
@project-bot project-bot bot added this to Needs review in Dev Jun 28, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 28, 2020
Dev automation moved this from By Code Owner to Reviewer approved Jun 29, 2020
@balloob balloob merged commit 856f8fd into home-assistant:dev Jun 30, 2020
Dev automation moved this from Reviewer approved to Done Jun 30, 2020
@bachya bachya deleted the guardian-entity-services branch June 30, 2020 03:04
platform = entity_platform.current_platform.get()

for service_name, schema, method in [
(SERVICE_DISABLE_AP, None, "async_disable_ap"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we target the entities without entity_id or area_id in the service call data (service schema)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right. Entity Platform doesn't handle this case. I guess it's broken now 馃し

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants