New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kwargs to send_magic_packet() service individually #37387
Conversation
Port kwarg was always being passed even if the config returned None which breaks in the 3rd party lib. You probably don't ever want to send just a port but the library supports it so both are optional and not dependent on one another.
Hi @stshontikidis, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Was able to fully test locally after working through a FE issue unrelated to this change. Logs on branch with fix
Current dev without fix. Note that sending just the port logs ok but I am very certain it does not actually send the service call with the port if you look at how the logging is being setup, it always logs with the kwargs but it is hitting the service call with only the positional args since it only checks for a broadcast address.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Wol stopped working for me after 0.112 upgrade and 0.112.4 doesn't fix the issue. |
@lollo78 how are you using WOL? Can you provide any config and logs? I am seeing no issue with using broadcast address with no broadcast port after the 112.4 update. |
@stshontikidis In configuration.yaml:
In includes/switches.yaml
In packages/pc_stanzetta.yaml:
I see this in log, but I don't know if is related:
|
@lollo78
then fire off the wake on lan switches that are not working and let us know the output. logs should be in |
Let's not discuss this on a merged PR. Please open a new issue. |
Port kwarg was always being passed even if the config returned None
which breaks in the 3rd party lib. You probably don't ever want to send
just a port but the library supports it so both are optional and not
dependent on one another.
Breaking change
Proposed change
Port kwarg was always being passed even if the config returned None
which breaks in the 3rd party lib. You probably don't ever want to send
just a port but the library supports it so both are optional and not
dependent on one another.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: