Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add denonavr solution tip for connection_error #37405

Merged
merged 3 commits into from Jul 5, 2020

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jul 3, 2020

Breaking change

Proposed change

see #37351 (comment)
disconnecting power supply and ethernet cable and connecting them apperently solves this error for some users.
Therefore include it as a tip in the error message during config flow.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added integration: denonavr small-pr PRs with less than 30 lines. labels Jul 3, 2020
@project-bot project-bot bot added this to Needs review in Dev Jul 3, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 3, 2020
@MartinHjelmare MartinHjelmare changed the title denonavr: add solution tip for connection_error Add denonavr solution tip for connection_error Jul 3, 2020
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare this can be merged.

@bdraco
Copy link
Member

bdraco commented Jul 5, 2020

MartinHjelmare this can be merged.

Please don't ping reviewers in PRs.

Dev automation moved this from By Code Owner to Reviewer approved Jul 5, 2020
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, this points the user to what to do next which is usually a good thing.

@bdraco bdraco merged commit 9927932 into home-assistant:dev Jul 5, 2020
Dev automation moved this from Reviewer approved to Done Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

cannot add denonavr integration using new config flow after 0.112.0 upgrade
3 participants