Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the main event loop for homekit #37441

Merged
merged 3 commits into from Jul 5, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 3, 2020

Waiting for ikalchev/HAP-python#270 .. now bumped to 2.9.2

May conflict with #37253

Proposed change

Use the main event loop for homekit. This change shaves off one thread per homekit bridge.

Update HAP-python to 2.9.2 which includes Paulus' changes and a bugfix for single byte reads

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jul 3, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 3, 2020
@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label Jul 3, 2020
Dev automation moved this from By Code Owner to Reviewer approved Jul 3, 2020
@balloob balloob mentioned this pull request Jul 3, 2020
20 tasks
@bdraco bdraco marked this pull request as draft July 3, 2020 22:24
@bdraco
Copy link
Member Author

bdraco commented Jul 3, 2020

Should be ready to go once upstream merge is done

@bdraco bdraco mentioned this pull request Jul 3, 2020
20 tasks
@bdraco bdraco marked this pull request as ready for review July 5, 2020 17:01
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Jul 5, 2020
@bdraco bdraco merged commit debb928 into home-assistant:dev Jul 5, 2020
Dev automation moved this from Reviewer approved to Done Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants