Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #3760, handle X10 unit numbers greater than 9. #3763

Merged
merged 1 commit into from
Oct 8, 2016

Conversation

mtl010957
Copy link
Contributor

Description:
Added the colon to the string array index to slice all characters past the first one, to handle unit numbers that have more than one digit, any greater than 9.

Related issue (if applicable): fixes #3760

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@mtl010957, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fotoetienne, @fabaff and @shmuelzon to be potential reviewers.

@fotoetienne
Copy link
Contributor

👍 LGTM. Thanks for the bug fix!

Copy link
Contributor

@fotoetienne fotoetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to be failing for an unrelated reason. This patch looks good. Thanks, @mtl010957

@balloob balloob added this to the 0.30.1 milestone Oct 8, 2016
@balloob
Copy link
Member

balloob commented Oct 8, 2016

🐬 top!

@balloob balloob merged commit 7882b19 into home-assistant:dev Oct 8, 2016
@mtl010957 mtl010957 deleted the x10-unit-number-fix branch October 8, 2016 20:46
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devices with X10 unit numbers greater than 9 do not show the correct state of the device
5 participants