Update automation logger to include object_id like scripts #37948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
During the development of the new script helper features it was decided that automation & script loggers should include the entity's object ID. E.g.,
homeassistant.components.automation.my_automation
orhomeassistant.components.script.my_script
. This was done for scripts, but was overlooked for automations. And for automations, the object ID isn't known when theAutomationEntity
is first created, but later when itsasync_added_to_hass()
method is called.This PR enhances the "script helper" class (
homeassistant.helpers.script.Script
) to allow the logger provided to be updated (including in any sub-scripts it has created forrepeat
andchoose
actions) with a new logger, and enhances the automation integration to create a new logger, once the object ID is known, and use it for itself as well as to update theScript
object created for itsaction
section.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: