Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfxtrx fixes for beta #37957

Merged
merged 2 commits into from Jul 18, 2020
Merged

Rfxtrx fixes for beta #37957

merged 2 commits into from Jul 18, 2020

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 18, 2020

Proposed change

Backports of fixes for rfxtrx

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

…tant#37819)

* Add event attribute to display last received event

* Restore state using event attribute

* Allow empty dict for device config

* Must also validate normal case

* Do early return
* Make sure sensor and binary_sensor force update

This make sure it's possible to react to events on all updates.

* Correct addition of binary sensors
@elupus elupus added this to the 0.113.0 milestone Jul 18, 2020
@probot-home-assistant probot-home-assistant bot added integration: rfxtrx merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. labels Jul 18, 2020
@balloob balloob merged commit 8b207df into home-assistant:rc Jul 18, 2020
@bouwew
Copy link
Contributor

bouwew commented Jul 19, 2020

@elupus

Maybe this is not the correct place to contact you, but I wanted to suggest you have a look at the code in this zip-file: https://github.com/brefra/python-plugwise/blob/master/example/plugwise_stick_1.0.1.zip
This custom_component has automatic detection of devices connected to the USB-ports. When I'm using this component, I'm seeing my RFXCOM-device also in the list of options. Quite useful for the Rfxtrx-component I think :)

P.S. my RFXCOM-device controls a Somfy sunscreen.

@elupus
Copy link
Contributor Author

elupus commented Jul 19, 2020

Once GUI config flow is in place we can have a look at it. Didn't find the repo for the custom component , so didn't find the code. (Can't open zips on my phone)

@bouwew
Copy link
Contributor

bouwew commented Jul 19, 2020

There's no repo for the plugwise-stick code (yet, I hope) so the zip is the best I can do.

@elupus elupus deleted the rc_rfxtrx branch July 24, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked cla-signed integration: rfxtrx merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants