Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ozw color temp #38012

Merged
merged 7 commits into from Jul 20, 2020
Merged

Fix ozw color temp #38012

merged 7 commits into from Jul 20, 2020

Conversation

tradiuz
Copy link
Contributor

@tradiuz tradiuz commented Jul 20, 2020

Proposed change

This PR fixes a potential overflow/underflow situation where if you set a color temp outside the light's range, the code will generate invalid color codes. It expands on @firstof9 's work, and adds testing to check and verify bad color temps don't generate bad output. I apologize about creating duplicate PRs, it took a couple tries to get the environment set up correctly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: This continues @firstof9 's work (PR#37636) on the ozw integration and rgb lights
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @cgarwood, @marcelveldt, @MartinHjelmare, mind taking a look at this pull request as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Ozw cct fix Fix ozw cct Jul 20, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

Not sure why some CI checks were skipped. Maybe try rebasing the PR to have the CI run again.

@cgarwood cgarwood changed the title Fix ozw cct Fix ozw color temp Jul 20, 2020
@cgarwood cgarwood merged commit 19870ea into home-assistant:dev Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants