Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YAML configuration support for IQVIA #38141

Merged
merged 2 commits into from Aug 3, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 24, 2020

Breaking change

Per ADR-0010, IQVIA can no longer be configured via YAML and must be configured from the UI. Existing IQVIA users have already had their integrations imported and only need to remove IQVIA-related items from configuration.yaml.

Proposed change

We deprecated monitored_conditions YAML support for IQVIA in 0.107.0 and were schedule to remove it in 0.114.0. Since ADR-0010 was approved in the intervening time, this PR goes a step further by removing YAML configuration support for IQVIA.

Additionally, the IQVIA config entry was using a lot of old code; this PR brings it to modern standards.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 Thanks for adjusting so quickly @bachya!

@frenck frenck merged commit 6fd39f5 into home-assistant:dev Aug 3, 2020
@bachya bachya deleted the remove-iqvia-conditions branch October 13, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants