Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeat with variables #38237

Merged
merged 3 commits into from Jul 27, 2020
Merged

Fix repeat with variables #38237

merged 3 commits into from Jul 27, 2020

Conversation

pnbruckner
Copy link
Contributor

@pnbruckner pnbruckner commented Jul 26, 2020

Proposed change

If a script is called with variables, the object holding those variables may be read-only (e.g., a MappingProxyType object.) If the script contains a repeat action, it will cause an exception. (See issue for details.)

This change causes the _ScriptRun object to make a writable copy of the variables so it can create additional variables during the run.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pnbruckner pnbruckner merged commit 1158925 into dev Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-repeat-with-variables branch July 27, 2020 21:51
@frenck frenck mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script repeat causes exception if script called with variables
4 participants