Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh_node_info command to OZW websocket api #38573

Merged
merged 6 commits into from Aug 12, 2020

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Aug 5, 2020

Proposed change

This PR adds a refresh_node_info command to the OZW websocket API. I had to re-structure the websocket_api file a bit to remove the class, as the websocket decorators didn't like being within a class.

Used for the frontend to provide feedback for the Refresh Node command.

Waiting for release of python-openzwave-mqtt 1.0.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @marcelveldt, @MartinHjelmare, mind taking a look at this pull request as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

homeassistant/components/ozw/websocket_api.py Outdated Show resolved Hide resolved
@cgarwood cgarwood marked this pull request as ready for review August 10, 2020 15:58
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cgarwood cgarwood merged commit 8cf0a01 into home-assistant:dev Aug 12, 2020
bahorn pushed a commit to bahorn/home-assistant-core that referenced this pull request Aug 12, 2020
)

* Add ozw refresh_node_info websocket api

* Remove extra unsubs definition

* Remove unused bits from refresh_node_info websocket

* Add tests

* Add unsubscribe test

* Wait for response in unsubscribe test
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
)

* Add ozw refresh_node_info websocket api

* Remove extra unsubs definition

* Remove unused bits from refresh_node_info websocket

* Add tests

* Add unsubscribe test

* Wait for response in unsubscribe test
@cgarwood cgarwood deleted the ozw_ws_refresh_node branch November 2, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants