Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyupgrade to v2.7.2 #38629

Merged
merged 2 commits into from Aug 8, 2020
Merged

Bump pyupgrade to v2.7.2 #38629

merged 2 commits into from Aug 8, 2020

Conversation

basnijholt
Copy link
Contributor

@basnijholt basnijholt commented Aug 7, 2020

Breaking change

Proposed change

Dependency update of pyupgrade from v2.3.0 to v2.7.2, see the changes here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 7, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to the changelogs in the PR description.
This applies to any PR with a dependency bump.

@frenck frenck added this to Needs review in Dev via automation Aug 7, 2020
@frenck frenck moved this from Needs review to Review in progress in Dev Aug 7, 2020
@basnijholt
Copy link
Contributor Author

Thanks @frenck, I have added a link to the change and I will keep that in mind for future PRs!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Thanks @basnijholt 👍

Dev automation moved this from Review in progress to Reviewer approved Aug 8, 2020
@frenck frenck merged commit d49c55a into home-assistant:dev Aug 8, 2020
Dev automation moved this from Reviewer approved to Done Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants