Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async_track_state_added_domain for tracking when states are added to a domain #38776

Merged
merged 5 commits into from Aug 12, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 12, 2020

Part 2 of reviving PR #23590

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Aug 12, 2020
@bdraco
Copy link
Member Author

bdraco commented Aug 12, 2020

After writing this out, it might be able to go with async_track_state_added_domain directly and use the existing underlying EVENT_STATE_CHANGED like async_track_state_change_event

This would negate the need to add a new event. Seems cleaner if the work here #23590 (comment) only needs to know about new entities in specific domains

@bdraco bdraco changed the title Fire event_state_added when a state is added after start Add async_track_state_added_domain for tracking when states are added to a domain Aug 12, 2020
@bdraco bdraco marked this pull request as ready for review August 12, 2020 17:55
@bdraco bdraco merged commit 45526f4 into home-assistant:dev Aug 12, 2020
bahorn pushed a commit to bahorn/home-assistant-core that referenced this pull request Aug 12, 2020
… to a domain (home-assistant#38776)

* Fire event_state_added when a state is added after start

* async_track_state_added_domain

* test

* naming

* coverage
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
… to a domain (home-assistant#38776)

* Fire event_state_added when a state is added after start

* async_track_state_added_domain

* test

* naming

* coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants