New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netatmo thermostat #3888
Netatmo thermostat #3888
Conversation
Just one test fails with
Really don't know how to fix this. |
local testing testing true Travis:
|
You can ignore |
@@ -37,6 +38,7 @@ | |||
vol.Required(CONF_PASSWORD): cv.string, | |||
vol.Required(CONF_SECRET_KEY): cv.string, | |||
vol.Required(CONF_USERNAME): cv.string, | |||
vol.Optional(CONF_DEVICES, default=DEFAULT_DEVICES): cv.ensure_list, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see a use case for making this configurable. It also should get validated against all valid values (which I guess are DEFAULT_DEVICES?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Get the latest data from NetAtmo API and updates the states.""" | ||
self._data.update() | ||
self._target_temperature = self._data.thermostatdata.setpoint_temp | ||
self._away = (True if self._data.setpoint_mode == 'away' else False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._away = self._data.setpoint_mode == 'away'
How do I do this?
when i do local testing? |
For future development, you can run just the linting tox or even just the commands for linting. See https://home-assistant.io/developers/development_testing/#testing-tips Thanks for your contribution! 🐬 |
Description:
This PR is to integrate the Netatmo Smart Thermostat in Home Assistant.
Sorry for the second PR, I messed up the first one. #3836
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1217
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass