Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netatmo climate boost/heat event handling #38923

Merged
merged 2 commits into from Aug 16, 2020

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Aug 15, 2020

Breaking change

Proposed change

This fixes an issue where the activation of heat mode of the Netatmo climate device is not reflected in the UI instantly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit decf3d3 into home-assistant:dev Aug 16, 2020
@cgtobi cgtobi deleted the netatmo_climate_fix_max branch August 16, 2020 10:31
brg468 pushed a commit to brg468/core that referenced this pull request Aug 17, 2020
* Fix boost event handling

* Replace strings with vars
balloob pushed a commit that referenced this pull request Aug 17, 2020
* Fix boost event handling

* Replace strings with vars
@balloob balloob mentioned this pull request Aug 17, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
* Fix boost event handling

* Replace strings with vars
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
* Fix boost event handling

* Replace strings with vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants