Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend IP ban / failed login notification information #39020

Merged
merged 2 commits into from Aug 18, 2020
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 18, 2020

Proposed change

Adds additional information to the IP ban notification and logs, namely:

  • A resolved hostname from the banned IP address
  • A user-agent (if known)

Resolves one of the top voted "What the heck?!" topics (on day 1).

https://community.home-assistant.io/t/wth-are-those-login-attempt-failed/219519

Example message:

Login attempt or request with invalid authentication from example.com (200.201.202.204) (Python/3.7 aiohttp/3.6.2)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (http) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck changed the title Extend IP ban notification information Extend IP ban / failed login notification information Aug 18, 2020
Dev automation moved this from Needs review to Reviewer approved Aug 18, 2020
@frenck frenck merged commit 475e709 into dev Aug 18, 2020
Dev automation moved this from Reviewer approved to Done Aug 18, 2020
@frenck frenck deleted the frenck-2020-0748 branch August 18, 2020 21:32
@cgarwood cgarwood added the WTH Issues & PRs generated from the "Month of What the Heck?" label Aug 20, 2020
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core has-tests integration: http new-feature small-pr PRs with less than 30 lines. WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants