Component setup error messages with markdown #3919
Conversation
|
@kellerza, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabianhjr and @persandstrom to be potential reviewers. |
| link: Optional[bool]=False): | ||
| """Print a persistent notification.""" | ||
| _PERSISTENT_ERRORS[component] = (_PERSISTENT_ERRORS.get(component, False) | ||
| or link) |
There was a problem hiding this comment.
- 38: W503 line break before binary operator
kellerza
force-pushed
the
bootstrap_notify
branch
from
14f5dcf
to
8592bee
Compare
| _PERSISTENT_ERRORS[component] = _PERSISTENT_ERRORS.get(component) or link | ||
| _lst = [HA_COMPONENT_URL.format(name) if link else name | ||
| for name, link in _PERSISTENT_ERRORS.items()] | ||
| message = ('The following components and platforms could not be set up:\n' |
There was a problem hiding this comment.
If we're using markdown, why not use list syntax for better readability.
There was a problem hiding this comment.
Another tip: add a link at the end to /dev-info so they can see the validation errors.
[See validation errors](/dev-info)
|
This is ok to merge when the Polymer support has been merged and comments addressed 👍 |
|
@kellerza |
kellerza
force-pushed
the
bootstrap_notify
branch
from
0931512
to
434466d
Compare
|
Comments addressed. Unfortunately I can't successfully test it yet. Feedback on gitter... |
kellerza
force-pushed
the
bootstrap_notify
branch
from
434466d
to
59dc197
Compare
kellerza
force-pushed
the
bootstrap_notify
branch
from
59dc197
to
b47b302
Compare
|
For now I have removed the relative |
kellerza
changed the title
Description:
This is an improvement on #3738 to log
persistent_notificationerror messages in more locations in bootstrap and include markdown.The messages have been simplified to only show a single card, instead of the original two cards. If a platform or component exist a link will be added to the home-assistant.io website.
Markdown support
@balloob should I clean up the
_PERSISTENT_ERRORSvar onHOME_ASSISTANT_START?CC: @justweb1
Related issue (if applicable): fixes #
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass