Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename entity base class for HMIPC #39243

Merged
merged 1 commit into from Aug 25, 2020
Merged

Rename entity base class for HMIPC #39243

merged 1 commit into from Aug 25, 2020

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Aug 25, 2020

Proposed change

This is a followup of #34462,#34590,#34591,#34593,#34595, ...

This PR renames the HomematicIP Cloud base class from HomematicipGenericDevice to HomematicipGenericEntity.
This PR also maintains some related comments.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Dev automation moved this from By Code Owner to Reviewer approved Aug 25, 2020
@balloob balloob merged commit 758c0ad into home-assistant:dev Aug 25, 2020
Dev automation moved this from Reviewer approved to Done Aug 25, 2020
@SukramJ SukramJ deleted the Rename_toEntity branch August 26, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants