Add device_class safety to synology_dsm storage binary_sensors

[Mariusthvdb]

Breaking change

Proposed change

Changes the state and icon to reflect the safety state this binary_sensor attempts to reflect.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @ProtoThis, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[Mariusthvdb]

thanks @MartinHjelmare

I had copied this from the Stookalert integration
Should I change it there too?
Must exist other spots too in the core HA binary_sensors. Isn't a check-all test available for this?

[MartinHjelmare]

Please do that in a separate PR.

[MartinHjelmare]

Thanks!

[Mariusthvdb]

ok, changed and imported device_class Safety, compare :

core/homeassistant/components/amcrest/binary_sensor.py

Line 8 in c8d49a8

from homeassistant.components.binary_sensor import (

[Mariusthvdb]

please advise what to do. Isort changes to

from homeassistant.components.binary_sensor import (DEVICE_CLASS_SAFETY,
                                                    BinarySensorEntity)

but also

from .const import (DOMAIN, SECURITY_BINARY_SENSORS,
                    STORAGE_DISK_BINARY_SENSORS, SYNO_API)

which was untouched by me...

which hardly seems correct? Don't want to keep creating new error messages here.

[MartinHjelmare]

Make sure to run isort in the project directory so that our isort config is picked up.

[MartinHjelmare]

Thanks!

[Mariusthvdb]

Hey @MartinHjelmare

shouldn't we change this

core/homeassistant/components/synology_dsm/const.py

Line 39 in 21dbce1

# Binary sensors

too now the device_class: safety is set in this PR?

[MartinHjelmare]

Yes, please.