Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipp to use CoordinatorEntity #39412

Merged
merged 3 commits into from Aug 30, 2020
Merged

Update ipp to use CoordinatorEntity #39412

merged 3 commits into from Aug 30, 2020

Conversation

ctalkington
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
@springstan
Copy link
Member

Test failures are unrelated:

=========================== short test summary info ============================
FAILED tests/components/marytts/test_tts.py::TestTTSMaryTTSPlatform::test_service_say_http_error
##[error]Process completed with exit code 1.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 馃憤

@bdraco bdraco merged commit 16a0bd7 into dev Aug 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the ctalkington-ipp-entity branch August 30, 2020 14:07
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
* update ipp to use CoordinatorEntity

* Update homeassistant/components/ipp/__init__.py

Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>

* Solve isort and black

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants