Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template filter timedelta #39608

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Sep 3, 2020

Proposed change

Add template filter timedelta to create a timedelta object from seconds. This can be used when sensors report a duration and can be converted into readable text when combined with relative_time(), e.g.:

{{ relative_time(now() - timedelta(seconds=3600)) }}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Sep 3, 2020

Can we accept all the units of time that time delta supports instead of creating a function that only works with seconds?

@balloob
Copy link
Member

balloob commented Sep 7, 2020

@bdraco you mean just exposing timedelta ?

@bdraco
Copy link
Member

bdraco commented Sep 7, 2020

@bdraco you mean just exposing timedelta ?

Yes

@jschlyter
Copy link
Contributor Author

@bdraco you mean just exposing timedelta ?

Yes

I'm happy to add all the timedelta kwargs if that's what we want.

@bdraco
Copy link
Member

bdraco commented Sep 7, 2020

@bdraco you mean just exposing timedelta ?

Yes

I'm happy to add all the timedelta kwargs if that's what we want.

That seems the most future proof so we don't end up with a timedeta_minutes etc

@jschlyter
Copy link
Contributor Author

jschlyter commented Sep 11, 2020

Based on comments from @bdraco I've change the code (but not yet the docs) to expose a raw datetime.timedelta.

Dev automation moved this from Needs review to Reviewer approved Sep 11, 2020
@balloob
Copy link
Member

balloob commented Sep 11, 2020

Can be merged once docs updated 👍

@bdraco bdraco merged commit 9b49ca3 into home-assistant:dev Sep 11, 2020
Dev automation moved this from Reviewer approved to Done Sep 11, 2020
@bdraco bdraco changed the title Add template filter timedelta_seconds to create a timedelta from seconds Add template filter timedelta to create a timedelta from seconds Sep 11, 2020
@basnijholt
Copy link
Contributor

Might be a good idea to change the name of the PR to

Add template filter timedelta

because the title isn't correct anymore and the release notes use the title (IIUC).

@jschlyter jschlyter deleted the template_timedelta_seconds branch September 22, 2020 12:42
@jschlyter jschlyter changed the title Add template filter timedelta to create a timedelta from seconds Add template filter timedelta Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants