-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for learning RF commands with Broadlink remotes #39671
Conversation
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration ( |
31207f4
to
083c64f
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
083c64f
to
b5ea72b
Compare
b5ea72b
to
6c4558a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks alright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments ✌️
It's better now. Thanks, guys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
* 'dev' of https://github.com/home-assistant/core: (32 commits) Disable parsing scientific/complex number notation in template type (home-assistant#43170) Remove relative time sensor from cert_expiry (home-assistant#42338) Further improve MFI tests (home-assistant#43167) Update translations Guard against empty ssdp locations (home-assistant#43156) Fix playing of Spotify URIs on Sonos (home-assistant#43154) Add missing 'hassio' translation string (home-assistant#43127) Streamline SimpliSafe errors (home-assistant#43117) Update xknx to 0.15.3 (home-assistant#42026) Fix beat calculation (home-assistant#43142) Mock time_date sensor tests (home-assistant#43141) [ci skip] Translation update Fix bug preventing Notion entities from updating their bridge (home-assistant#43122) Bump hass-nabucasa to 0.37.2 (home-assistant#43146) Shelly: minor improvements (home-assistant#43138) Add support for learning RF commands with Broadlink remotes (home-assistant#39671) Fix incorrect Notion battery state calculation (home-assistant#43108) Bump hatasmota to 0.0.30 (home-assistant#43140) Add VSCode debug launch conf (home-assistant#43130) Revert "shelly_naming" rebase errors (home-assistant#43134) ...
…istant#39671) * Add support for learning RF codes with Broadlink remotes * Rename INFRARED and RADIOFREQUENCY to COMMAND_TYPE_IR and COMMAND_TYPE_RF * Rewrite if expression as normal if statement * Use COMMAND_TYPE_IR directly and improve error messages
…istant#39671) * Add support for learning RF codes with Broadlink remotes * Rename INFRARED and RADIOFREQUENCY to COMMAND_TYPE_IR and COMMAND_TYPE_RF * Rewrite if expression as normal if statement * Use COMMAND_TYPE_IR directly and improve error messages
Proposed change
This PR adds support for learning RF commands with Broadlink devices. These are the proposed changes:
command_type: rf
inremote.learn_command
service.remote.learn_command
withcommand_type: ir
.Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: