Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change template loop detection strategy to allow self-referencing updates when there are multiple templates #39943

Merged
merged 3 commits into from Sep 12, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 11, 2020

Proposed change

This reverts #39897

Change template loop detection strategy to allow a self-referencing update

Loop detection now only triggers if we have a sequence of self referencing
updates greater than or equal to the number of templates.

This allows additional attributes in template entities to be self-referencing
as long as all templates in the entity are not self-referencing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2020
@bdraco bdraco added this to the 0.115.0 milestone Sep 11, 2020
@bdraco
Copy link
Member Author

bdraco commented Sep 11, 2020

unrelated test failure .. . again FAILED tests/components/light/test_device_trigger.py::test_if_fires_on_state_change[pyloop]

Dev automation moved this from Needs review to Reviewer approved Sep 12, 2020
@balloob balloob merged commit aaa8083 into home-assistant:dev Sep 12, 2020
Dev automation moved this from Reviewer approved to Done Sep 12, 2020
balloob pushed a commit that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Template loop detection breaks useful self references in templates
3 participants