Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohomekit version (regression fix) #40064

Merged

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Sep 14, 2020

Proposed change

Bump aiohomekit to latest release. This is stop a regression: This version reverts a change introduced when 0.115 moved to aiohomekit 0.2.47. The change was meant to improve reconnection handling, but may have actually made it worse for some devices. As it seems to be behind some reliability issues (see Jc2k/aiohomekit#20) it has been reverted for now.

This also fixes support for the Heatmiser Neohub.

There are other unrelated changes in this tag. Mostly caused by linter upgrads (isort and black) and by added pyupgrade to bring aiohomekit more in line with HA. We also switched to GitHub actions as well. Finally the tag adds some supporting code for HomeKit camera, but this is unused by Home Assistant. All of these changes are minimal risk.

I'd like to get this into 0.115.0 to stop any regression getting released if possible.

Jc2k/aiohomekit@0.2.49...0.2.53

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Sep 14, 2020
@Jc2k Jc2k added this to the 0.115.0 milestone Sep 14, 2020
Dev automation moved this from By Code Owner to Reviewer approved Sep 14, 2020
@MartinHjelmare
Copy link
Member

I added a link to the github commit compare range for the version bump to the PR description.

@MartinHjelmare MartinHjelmare merged commit f1cc518 into home-assistant:dev Sep 14, 2020
Dev automation moved this from Reviewer approved to Done Sep 14, 2020
@Jc2k Jc2k deleted the homekit_controller_fix_regression_115 branch August 5, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants