Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt Splunk using custom library #40123

Merged
merged 9 commits into from Sep 20, 2020
Merged

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Sep 16, 2020

Proposed change

Changed the Splunk integration to use an external Pypi library, rather than requests. This indirectly has fixed a data formatting issue the previous version of this integration had, introduces batching to reduce the number of connections, and validates the Splunk Token on setup.

By design the integration will not fail if Splunk is down, as this can be expected when restarting a physical host that is running both Home Assistant and Splunk.

These fixes has previously been submitted as PR #39774 and #40015, reworked based on feedback from @MartinHjelmare

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

No change from documentation at https://www.home-assistant.io/integrations/splunk/

Additional information

n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/splunk/manifest.json Outdated Show resolved Hide resolved
requirements_all.txt Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 16, 2020
Bre77 and others added 2 commits September 16, 2020 18:58
Recommended Fixes

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@Bre77 Bre77 changed the title Rebuilt Splunk using splunk_data_sender Rebuilt Splunk using custom library Sep 18, 2020
Dev automation moved this from Review in progress to Reviewer approved Sep 20, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 4f5d3b4 into home-assistant:dev Sep 20, 2020
Dev automation moved this from Reviewer approved to Done Sep 20, 2020
@Bre77 Bre77 deleted the splunk branch September 20, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants