New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuilt Splunk using custom library #40123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
MartinHjelmare
requested changes
Sep 16, 2020
Recommended Fixes Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Bre77
changed the title
Rebuilt Splunk using splunk_data_sender
Rebuilt Splunk using custom library
Sep 18, 2020
MartinHjelmare
approved these changes
Sep 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Changed the Splunk integration to use an external Pypi library, rather than requests. This indirectly has fixed a data formatting issue the previous version of this integration had, introduces batching to reduce the number of connections, and validates the Splunk Token on setup.
By design the integration will not fail if Splunk is down, as this can be expected when restarting a physical host that is running both Home Assistant and Splunk.
These fixes has previously been submitted as PR #39774 and #40015, reworked based on feedback from @MartinHjelmare
Type of change
Example entry for
configuration.yaml
:No change from documentation at https://www.home-assistant.io/integrations/splunk/
Additional information
n/a
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: