Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device name stored in device_info for tag scan in ESPHome #40130

Merged

Conversation

jesserockz
Copy link
Member

Breaking change

@MartinHjelmare
Following on from #40128
This uses the device_info name instead of having the device_id sent through the api everytime. This way it cannot be spoofed too.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@jesserockz
Copy link
Member Author

jesserockz commented Sep 16, 2020

@MartinHjelmare I was ready to push this one extra commit when you merged the last PR with a comment from esphome/esphome#1281 (comment)

@probot-home-assistant
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with an integration (esphome) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title ESPHome - Use the device name stored in the device_info for tag scan Use device name stored in device_info for tag scan in ESPHome Sep 16, 2020
Dev automation moved this from Needs review to Reviewer approved Sep 16, 2020
@MartinHjelmare
Copy link
Member

Let me know when we're ready to merge.

@jesserockz
Copy link
Member Author

jesserockz commented Sep 16, 2020

Sorry, yeah this is tested and working locally and ready to merge in =)
Thanks

@MartinHjelmare MartinHjelmare merged commit 16e0ed9 into home-assistant:dev Sep 16, 2020
Dev automation moved this from Reviewer approved to Done Sep 16, 2020
@balloob balloob added this to the 0.115.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants