New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cmus remote disconnections #40284
Merged
MartinHjelmare
merged 7 commits into
home-assistant:dev
from
kingo55:cmus-remote-reconnection
Feb 12, 2021
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2368141
fix: cmus reconnect remote on disconnection
kingo55 f77a968
Move cmus connection to separate class
kingo55 6a2a80d
Address flake tests
kingo55 0980614
Address additional flake tests
kingo55 94150fe
Move cmus connection outside of __init__
kingo55 c9284dc
Remove redundant exception handler
kingo55 4435bff
Clean up
MartinHjelmare File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this exception occurs, reconnect is called, but status is not set like in the previous block. I think this will cause
NameError
forif not status
becausestatus
is never set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we attempt a reconnection here, the status should be accessible if it successfully reconnects.
Though since reconnections are usually from the cmus server being off, I think this might be sensible not to try updating the status here.